[Cropper] Always apply rotation in Crop::getCroppedImage() and Crop::getCroppedThumbnail()#3433
Merged
Kocal merged 1 commit intosymfony:3.xfrom Apr 4, 2026
Merged
Conversation
Kocal
reviewed
Apr 4, 2026
Member
Kocal
left a comment
Kocal
left a comment
There was a problem hiding this comment.
Oops, nice catch!
Shouldn't we always apply the rotation like the deprecation message told us? Meaning, we can remove the $applyRotation parameter
Kocal
added
Status: Needs Work
carsonbot
changed the title
Contributor
Author
At first look, I didn't like the idea of implicit rotation based on whether or not related options were present. |
carsonbot
added
Status: Needs Review
MrYamous
changed the title
applyRotation parameter
Kocal
reviewed
Apr 4, 2026
Kocal
force-pushed
the
cropper-road-to-3x
branch
from
adbf325 to
6c045e4
Compare
…p::getCroppedThumbnail()`
Kocal
force-pushed
the
cropper-road-to-3x
branch
from
6c045e4 to
50060bf
Compare
Kocal
changed the title
applyRotation parameterCrop::getCroppedImage() and Crop::getCroppedThumbnail()
Member
|
Thank you @MrYamous. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw some PR about 3.x and tests dedicated to this change were removed, but not yet the code